Differential D17176

Allow sharing of empty files
ClosedPublic
Actions

Authored by eduisters on Nov 26 2018, 5:10 PM.

Details

Reviewers
albertvaka
Group Reviewers
KDE Connect
Commits
R225:5d50358f3f37: Allow sharing of empty files
Summary

When an empty file is shared with the desktop a server is started that times-out after 10sec
this causes a notification to be displayed telling the user the transfer failed

Test Plan

Send an empty file to the desktop
A notification should be displayed telling the user the transfer succeeded

Diff Detail

Repository
R225 KDE Connect - Android application
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
eduisters created this revision.Nov 26 2018, 5:10 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptNov 26 2018, 5:10 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
eduisters requested review of this revision.Nov 26 2018, 5:10 PM
albertvaka added a subscriber: albertvaka.Nov 26 2018, 5:37 PM

This will not send the file, though...

albertvaka added a comment.Nov 26 2018, 5:41 PM

Oh, I just saw the other patch that makes this work. It's not backwards compatible, but we can probably go with that as it's not very common to send 0 byte files.

eduisters added a comment.EditedNov 26 2018, 7:42 PM

I can't make something work in a backwards compatible way because it has never worked on either side, desktop and android use different ways to detect the presents of a payload

albertvaka accepted this revision.Nov 28 2018, 1:39 PM
This revision is now accepted and ready to land.Nov 28 2018, 1:39 PM
Closed by commit R225:5d50358f3f37: Allow sharing of empty files (authored by eduisters). · Explain WhyNov 28 2018, 2:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 46408

View Options

src/org/kde/kdeconnect/Backends/LanBackend/LanLink.java

Loading...