Handle receiving empty file from Android
ClosedPublic

Authored by eduisters on Nov 26 2018, 5:06 PM.

Details

Summary

When a file share is received the share plugin does not detect that an empty file is being shared

Test Plan

Send an empty file from android
The empty file should be created

Diff Detail

Repository
R224 KDE Connect
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
eduisters created this revision.Nov 26 2018, 5:06 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptNov 26 2018, 5:06 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
eduisters requested review of this revision.Nov 26 2018, 5:06 PM
eduisters edited the summary of this revision. (Show Details)Nov 26 2018, 5:08 PM
eduisters edited the test plan for this revision. (Show Details)
albertvaka accepted this revision.Nov 28 2018, 1:31 PM
albertvaka added a subscriber: albertvaka.

Maybe add a comment to the else branch explaining this is for empty files? It's not obvious from the code.

This revision is now accepted and ready to land.Nov 28 2018, 1:31 PM
This revision was automatically updated to reflect the committed changes.