Handle receiving empty file from Android
ClosedPublic
Actions

Authored by eduisters on Nov 26 2018, 5:06 PM.

Details

Reviewers

albertvaka

Group Reviewers

KDE Connect

Commits

R224:538872ddc888: Handle receiving empty file from Android

Summary

When a file share is received the share plugin does not detect that an empty file is being shared

Test Plan

Send an empty file from android
The empty file should be created

Repository

R224 KDE Connect

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kdeconnect. · View Herald Transcript

eduisters requested review of this revision.Nov 26 2018, 5:06 PM

eduisters edited the test plan for this revision. (Show Details)

Maybe add a comment to the else branch explaining this is for empty files? It's not obvious from the code.

This revision is now accepted and ready to land.Nov 28 2018, 1:31 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			plugins/share/shareplugin.h (3 lines)
M			plugins/share/shareplugin.cpp (38 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	46278	fb09907		Nov 26 2018, 5:06 PM	★	★
Diff 2	46409	a7db44a	R224:538872ddc88824410cd495ed3da930facd4c33da	Nov 28 2018, 2:50 PM	★	★