[Desktop Toolbox] Close toolbox popup before triggering action
ClosedPublic
Actions

Authored by broulik on May 30 2016, 1:12 PM.

Details

Reviewers

bshah

Group Reviewers

Plasma

Commits

Summary

The still open dialog might steal focus from a auto hiding panel like the widget explorer causing it to close immediately after opening it.

BUG: 363161
FIXED-IN: 5.6.5

Test Plan

Opened the widget explorer through the desktop toolbox multiple times, I can no longer reproduce the issue. The other entries also still work.

Repository

R119 Plasma Desktop

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

broulik retitled this revision from to [Desktop Toolbox] Close toolbox popup before triggering action.

broulik updated this object.

broulik edited the test plan for this revision. (Show Details)

broulik added a reviewer: Plasma.

broulik set the repository for this revision to R119 Plasma Desktop.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

This revision is now accepted and ready to land.May 30 2016, 1:18 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			toolboxes/desktoptoolbox/contents/ui/ToolBoxItem.qml (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	4065			May 30 2016, 1:10 PM	★	★
Diff 2	4067	62b272f	rPLASMADESKTOPe3bf0a5bb0a973a104c52ab3c22a8928105cad9f	May 30 2016, 1:27 PM	★	★