Differential D17131

Fix problem model test on Windows. Make sure that when we create a path the root of that path is created according to what is expected on the current platform. E.g. C: on Windows.
ClosedPublic
Actions

Authored by volden on Nov 24 2018, 8:34 AM.

Details

Reviewers
brauch
Group Reviewers
KDevelop
Commits
R32:436303a96e42: Fix problem model test on Windows. Make sure that when we create a path the…
R32:12034dbdd98f: Fix problem model test on Windows. Make sure that when we create a path the…
Summary

Fix problem model test on Windows. Make sure that when we create a path the root of that path is created according to what is expected on the current platform.

Test Plan

Build and test on Windows. See that the test is passing. Build on Linux and verify that test is passing (As before)

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
volden created this revision.Nov 24 2018, 8:34 AM
Restricted Application added a project: KDevelop. · View Herald TranscriptNov 24 2018, 8:34 AM
volden requested review of this revision.Nov 24 2018, 8:34 AM
brauch accepted this revision.Nov 24 2018, 9:27 AM
brauch added a subscriber: brauch.

Looks good, thanks!

This revision is now accepted and ready to land.Nov 24 2018, 9:27 AM
volden added a comment.Nov 24 2018, 1:57 PM

@brauch Since this is a fairly simple patch. I'm thinking push to 5.3 and merge into master. Agree?

brauch added a comment.Nov 24 2018, 2:13 PM

Since it only touches a test, I don't see any issues with putting it into 5.3. Thanks!

Closed by commit R32:436303a96e42: Fix problem model test on Windows. Make sure that when we create a path the… (authored by volden). · Explain WhyNov 24 2018, 2:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 46120

View Options

kdevplatform/shell/tests/test_problemmodel.cpp

Loading...