[server] Don't destroy ContrastInterface when parent SurfaceInterface is destroyed
ClosedPublic

Authored by graesslin on May 30 2016, 8:26 AM.

Details

Summary

Destroying the ContrastInterface on the server side before the client has
a chance to cleanup results in a protocol error:
wl_display@1: error 0: invalid object 7

Which would terminate the client. If we would not destroy the resource,
but only delete the ContrastInterface it could result in
heap-use-after-free.

So just don't do anything, the client needs to cleanup which will result
in the ContrastInterface being deleted.

Diff Detail

Repository
R127 KWayland
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 4056.May 30 2016, 8:26 AM
graesslin retitled this revision from to [server] Don't destroy ContrastInterface when parent SurfaceInterface is destroyed.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptMay 30 2016, 8:26 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sebas accepted this revision.May 31 2016, 8:50 PM
sebas added a reviewer: sebas.
This revision is now accepted and ready to land.May 31 2016, 8:50 PM
This revision was automatically updated to reflect the committed changes.