Differential D17077

Make test outputmodel pass on windows.
ClosedPublic
Actions

Authored by volden on Nov 21 2018, 4:05 PM.

Details

Reviewers
kfunk
Group Reviewers
KDevelop
Commits
R32:10760f1c7fb0: Merge branch '5.3'
R32:3dae49147893: Make test outputmodel pass on windows.
Summary

When doing the benchmark test on windows. Make sure that we use windows paths. Otherwise the test will fail (in debug builds) in an assert in util/path.cpp

Test Plan

Run the test in a Windows debug build environment. Before patch it fails. After patch is applied it succeeds. Run test on Linux and see that test stil completes

Diff Detail

Repository
R32 KDevelop
Branch
fixOutputmodeltestwin (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5216
Build 5234: arc lint + arc unit
volden created this revision.Nov 21 2018, 4:05 PM
Restricted Application added a project: KDevelop. · View Herald TranscriptNov 21 2018, 4:05 PM
volden requested review of this revision.Nov 21 2018, 4:05 PM
kfunk accepted this revision.Nov 21 2018, 4:24 PM
This revision is now accepted and ready to land.Nov 21 2018, 4:24 PM
kfunk added a comment.Nov 21 2018, 4:24 PM

To 5.3 branch, please

Closed by commit R32:3dae49147893: Make test outputmodel pass on windows. (authored by volden). · Explain WhyNov 21 2018, 5:25 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 45960

View Options

kdevplatform/outputview/tests/test_outputmodel.cpp

Loading...