CoreGraphics, CoreFoundation, IOKit are required.
Details
Details
Tested using Homebrew on MacOS.
Diff Detail
Diff Detail
- Repository
- R223 Okular
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
@rjvbb what do you say? makes sense?
Yes, this is required. I've got a bunch of patches for Okular I never got around to sub/committing.
The patch as proposed is OK as a packaging patch, but requires some polishing before it's fit for upstreaming. You can take inspiration from my version of this patch:
--- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -216,7 +216,7 @@ generate_export_header(okularcore BASE_NAME okularcore EXPORT_FILE_NAME "${CMAKE # Special handling for linking okularcore on OSX/Apple IF(APPLE) - SET(OKULAR_IOKIT "-framework IOKit" CACHE STRING "Apple IOKit framework") + SET(OKULAR_APPLE_FRAMEWORKS "-framework IOKit -framework CoreGraphics -framework CoreFoundation" CACHE STRING "required Apple frameworks") ENDIF(APPLE) # Extra library needed by imported synctex code on Windows @@ -226,7 +226,7 @@ endif(WIN32) target_link_libraries(okularcore PRIVATE - ${OKULAR_IOKIT} + ${OKULAR_APPLE_FRAMEWORKS} ${SHLWAPI} KF5::Archive KF5::JS
Comment Actions
Please move as a Merge Request in https://invent.kde.org/kde/okular
We have pre-commit CI and lots of checks including clazy and clang-tidy there so it's a much better place for doing the review/approval/merge of the code.