Differential D1705

[System Tray] Don't iterate keys()
ClosedPublic
Actions

Authored by broulik on May 29 2016, 5:16 PM.

Details

Reviewers
apol
Group Reviewers
Plasma
Commits
R120:cc47d2bfca93: [System Tray] Don't iterate keys()
R871:cc47d2bfca93: [System Tray] Don't iterate keys()
Summary

Instead of allocating a temprary list just to iterate over it and then doing a value() lookup, just use iterators instead.

Test Plan

Started VLC, got mediaplayer applet, closed VLC, applet disappeared

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 4038.May 29 2016, 5:16 PM
broulik retitled this revision from to [System Tray] Don't iterate keys().
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma. · View Herald TranscriptMay 29 2016, 5:16 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik updated this object.May 29 2016, 5:17 PM
apol accepted this revision.May 29 2016, 10:18 PM
apol added a reviewer: apol.
apol added a subscriber: apol.

Good stuff! Clazy? Or you actually found this to be a paint point?

This revision is now accepted and ready to land.May 29 2016, 10:18 PM
Closed by commit R120:cc47d2bfca93: [System Tray] Don't iterate keys() (authored by broulik). · Explain WhyMay 31 2016, 9:26 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mapplets/systemtray/systemtray.cpp (13 lines)

Diff 4087

View Options

applets/systemtray/systemtray.cpp

Loading...