Recalculate connected hash only on change and emit signal
AcceptedPublic
Actions

Authored by romangg on Nov 18 2018, 7:26 PM.

Details

Reviewers

Group Reviewers

Summary

Instead of recomputing the connected outputs hash on every access, store
it in Config and only recalculate it on a change of one of its inputs.

Also inform consumers about the change via a separate signal.

Test Plan

Autotest extended.

Repository

R110 KScreen Library

Branch

configConnectedOutputsHashChanged

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 5093
Build 5111: arc lint + arc unit

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

romangg requested review of this revision.Nov 18 2018, 7:26 PM

Checking the edid is necessary, because it might be set asynchronously and before that the hash is based on the output name only.

That said I can only test this with the autotest, but not with my hardware, because KWin does not like to send the edid values for my screens.

This revision is now accepted and ready to land.Nov 23 2018, 12:33 PM

			Path	Packages
M			autotests/testscreenconfig.cpp (32 lines)
M			src/config.h (1 line)
M			src/config.cpp (38 lines)
M			src/output.h (1 line)
M			src/output.cpp (2 lines)

Commit	Tree	Parents	Author	Summary	Date
b73229569eb5	bf5b42d039fb	8c8bf0f2dbc5	Roman Gilg	Always calculate non-empty hashes	Nov 18 2018, 5:33 PM
8c8bf0f2dbc5	165665038411	785ae00733ee	Roman Gilg	edidSet signal	Nov 18 2018, 4:07 PM
785ae00733ee	134eac9d052e	4be57b2027fe	Roman Gilg	Recalculate connected hash on change	Nov 18 2018, 4:00 PM