Differential D16955

[autotests] Hopefully stabilise TestShellClient
ClosedPublic
Actions

Authored by davidedmundson on Nov 17 2018, 12:07 PM.

Details

Reviewers
graesslin
Group Reviewers
KWin
Commits
R108:6c71403281b2: [autotests] Hopefully stabilise TestShellClient
Summary

Apparently this test is flaky, based on the output I recieved we had
processed the un-fullscreen but not the un-maximise.

It seems possible the wayland thread could process when there's only one
request in the queue.

Test Plan

Couldn't reproduce the original issue, it's a blind patch but the
current tests still pass.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: KWin. · View Herald TranscriptNov 17 2018, 12:07 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
davidedmundson requested review of this revision.Nov 17 2018, 12:07 PM
graesslin added a subscriber: graesslin.Nov 17 2018, 12:36 PM

I'll add the patch to my build and try to reproduce. I got the problem about every third run, so if it runs 10 times without failure I'll call it success

graesslin accepted this revision.Nov 17 2018, 12:49 PM
xvfb-run ctest --output-on-failure --repeat-until-fail 10 -I 52,52 
Test project /home/martin/build/kde/workspace/kwin
    Start 52: kwin-testShellClient
    Test #52: kwin-testShellClient .............   Passed   29.80 sec
    Start 52: kwin-testShellClient
    Test #52: kwin-testShellClient .............   Passed   29.90 sec
    Start 52: kwin-testShellClient
    Test #52: kwin-testShellClient .............   Passed   30.02 sec
    Start 52: kwin-testShellClient
    Test #52: kwin-testShellClient .............   Passed   29.96 sec
    Start 52: kwin-testShellClient
    Test #52: kwin-testShellClient .............   Passed   30.00 sec
    Start 52: kwin-testShellClient
    Test #52: kwin-testShellClient .............   Passed   30.00 sec
    Start 52: kwin-testShellClient
    Test #52: kwin-testShellClient .............   Passed   30.01 sec
    Start 52: kwin-testShellClient
    Test #52: kwin-testShellClient .............   Passed   29.99 sec
    Start 52: kwin-testShellClient
    Test #52: kwin-testShellClient .............   Passed   29.99 sec
    Start 52: kwin-testShellClient
1/1 Test #52: kwin-testShellClient .............   Passed   30.02 sec

100% tests passed, 0 tests failed out of 1

Total Test time (real) = 299.72 sec
This revision is now accepted and ready to land.Nov 17 2018, 12:49 PM
Closed by commit R108:6c71403281b2: [autotests] Hopefully stabilise TestShellClient (authored by davidedmundson). · Explain WhyNov 17 2018, 12:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 45661

View Options

autotests/integration/shell_client_test.cpp

Loading...