Differential D16935

Align behaviour of the desktop app with the Android app
ClosedPublic
Actions

Authored by alexkovrigin on Nov 16 2018, 8:40 PM.

Details

Reviewers
albertvaka
nicolasfella
Group Reviewers
KDE Connect
Commits
R224:1cee137dcbb9: Align behaviour of the desktop app with the Android app
Summary

Now devices are shown same as in Android app, as in Kirigami app (kcapp)

Test Plan
  • Build kdeconnect, using the experimental version
  • Try pairing, unpairing, connecting and disconnected devices.
  • See the difference.

Diff Detail

Repository
R224 KDE Connect
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
alexkovrigin created this revision.Nov 16 2018, 8:40 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptNov 16 2018, 8:40 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
alexkovrigin requested review of this revision.Nov 16 2018, 8:40 PM
nicolasfella requested changes to this revision.Nov 26 2018, 3:23 PM
nicolasfella added a subscriber: nicolasfella.

Sorry for keeping you waiting so long. There is a issue that needs to be resolved.

app/qml/FindDevicesPage.qml
63

Here we want to show all devices, so no displayFilter is needed at all

This revision now requires changes to proceed.Nov 26 2018, 3:23 PM
alexkovrigin updated this revision to Diff 46269.Nov 26 2018, 4:17 PM
  • Align behaviour of the desktop app with the Android app (small bugfix)
alexkovrigin added inline comments.Nov 26 2018, 4:19 PM
app/qml/FindDevicesPage.qml
63

I tried deleting the lines 62-64, but no devices were shown at all, so maybe I should put here a boolean OR?

nicolasfella added inline comments.Nov 26 2018, 4:59 PM
app/qml/FindDevicesPage.qml
63

Just do

sourceModel: DevicesModel {}
alexkovrigin updated this revision to Diff 46282.Nov 26 2018, 5:39 PM
  • Align behaviour of the desktop app with the Android app (small bugfix 2)
alexkovrigin marked 3 inline comments as done.Nov 26 2018, 5:39 PM
This revision is now accepted and ready to land.Nov 26 2018, 9:14 PM
Closed by commit R224:1cee137dcbb9: Align behaviour of the desktop app with the Android app (authored by alexkovrigin, committed by nicolasfella). · Explain WhyNov 26 2018, 9:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mapp/qml/FindDevicesPage.qml (8 lines)
Mapp/qml/main.qml (4 lines)

Diff 46292

View Options

app/qml/FindDevicesPage.qml

Loading...
View Options

app/qml/main.qml

Loading...