Differential D16909

Align behaviour of the desktop app with the Android appP.S.It's a GCI task.
AbandonedPublic
Actions

Authored by alexkovrigin on Nov 15 2018, 7:52 PM.

Details

Reviewers
albertvaka
Group Reviewers
KDE Connect
Summary

Now devices are shown same as in Android app, as in Kirigami app (kcapp)

Test Plan
  • Build kdeconnect, using the experimental version
  • Try pairing, unpairing, connecting and disconnected devices.
  • See the difference

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5006
Build 5024: arc lint + arc unit
alexkovrigin created this revision.Nov 15 2018, 7:52 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptNov 15 2018, 7:52 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
alexkovrigin requested review of this revision.Nov 15 2018, 7:52 PM
albertvaka retitled this revision from Align behaviour of the desktop app with the Android app P.S. It's a GCI task. to Align behaviour of the desktop app with the Android appP.S.It's a GCI task..Nov 16 2018, 10:19 AM
albertvaka added a reviewer: KDE Connect.
albertvaka requested changes to this revision.Nov 16 2018, 10:36 AM
albertvaka added a subscriber: albertvaka.
albertvaka added inline comments.
app/qml/main.qml
107

As I commented in the GCI task: you need to use a bitwise OR (|) to add flags together, instead of a logic AND (&&), which in this case will be always true (because both flags are an integer != 0).

This revision now requires changes to proceed.Nov 16 2018, 10:36 AM
alexkovrigin updated this revision to Diff 45613.Nov 16 2018, 8:31 PM

Fix an error, found by albertvaka in main.qml

alexkovrigin updated this revision to Diff 45615.Nov 16 2018, 8:35 PM
alexkovrigin marked an inline comment as done.
  • Fix the update fail of the first diff.
alexkovrigin abandoned this revision.Nov 16 2018, 8:41 PM

Messed things up, I've made a new one: https://phabricator.kde.org/D16935

Revision Contents
Changeset List

PathPackages
DMapp/qml/FindDevicesPage.qml (77 lines)
DMapp/qml/main.qml (143 lines)

Diff 45615

View Options

app/qml/FindDevicesPage.qml

Loading...
View Options

app/qml/main.qml

Loading...