Differential D16831

Fix crash introduced with a7ba6eb00095df86ae6bc482932
ClosedPublic
Actions

Authored by gregormi on Nov 11 2018, 9:56 PM.

Details

Reviewers
cullmann
Group Reviewers
Kate
Commits
R40:5850022cd0e2: Fix crash introduced with a7ba6eb00095df86ae6bc482932
Summary

Reason for the crash: with "Quick Open: Remove "file:///" prefix from file paths"
(a7ba6eb00095df86ae6bc4829327a41e521f1c1c) the Url prefix file:///
was removed and therefore we hit an assertion (missing protocol) when
trying to open a file from the Quick Open view.

Diff Detail

Repository
R40 Kate
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
gregormi created this revision.Nov 11 2018, 9:56 PM
Restricted Application added a project: Kate. · View Herald TranscriptNov 11 2018, 9:56 PM
Restricted Application added a subscriber: kwrite-devel. · View Herald Transcript
gregormi requested review of this revision.Nov 11 2018, 9:56 PM
cullmann requested changes to this revision.Nov 12 2018, 7:02 AM
cullmann added a subscriber: cullmann.

Hmm, I don't think that is the right way, what happens with remote files?
Perhaps we should just store the unchanged url in some extra data field?

This revision now requires changes to proceed.Nov 12 2018, 7:02 AM
gregormi updated this revision to Diff 45734.Nov 18 2018, 4:50 PM

Use extra field in model to store original Url

cullmann accepted this revision.Nov 19 2018, 5:31 AM

Looks ok, thanks.

This revision is now accepted and ready to land.Nov 19 2018, 5:31 AM
gregormi edited the summary of this revision. (Show Details)Nov 19 2018, 10:04 PM
Closed by commit R40:5850022cd0e2: Fix crash introduced with a7ba6eb00095df86ae6bc482932 (authored by gregormi). · Explain WhyNov 19 2018, 10:04 PM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 3 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Path
No data available.

Diff 45846