Differential D16829

Allow accessing deviceName from qml
ClosedPublic
Actions

Authored by blaws on Nov 11 2018, 6:53 PM.

Details

Reviewers
broulik
Commits
R224:e47fb170061a: Allow accessing deviceName from qml
Summary

This allows it to be used outside of comboboxes in qml

Diff Detail

Repository
R224 KDE Connect
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
blaws created this revision.Nov 11 2018, 6:53 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptNov 11 2018, 6:53 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
blaws requested review of this revision.Nov 11 2018, 6:53 PM
broulik added a subscriber: broulik.Nov 11 2018, 6:55 PM

NameModelRole is Qt::DisplayRole and can be accessed as model . display but since we also have duplicate role names for e.g IconNameRole that is Qt::DecorationRole I think this change makes sense.

blaws added a comment.Nov 11 2018, 7:24 PM

Yeah, it seems most qton their github apps give it a name aswell

broulik accepted this revision.Nov 11 2018, 7:25 PM
This revision is now accepted and ready to land.Nov 11 2018, 7:25 PM
Closed by commit R224:e47fb170061a: Allow accessing deviceName from qml (authored by blaws). · Explain WhyNov 11 2018, 7:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Minterfaces/devicesmodel.cpp (1 line)

Diff 45321

View Options

interfaces/devicesmodel.cpp

Loading...