Allow accessing deviceName from qml
ClosedPublic

Authored by blaws on Nov 11 2018, 6:53 PM.

Details

Summary

This allows it to be used outside of comboboxes in qml

Diff Detail

Repository
R224 KDE Connect
Branch
devicename (branched from master)
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 4843
Build 4861: arc lint + arc unit
blaws created this revision.Nov 11 2018, 6:53 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptNov 11 2018, 6:53 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
blaws requested review of this revision.Nov 11 2018, 6:53 PM

NameModelRole is Qt::DisplayRole and can be accessed as model . display but since we also have duplicate role names for e.g IconNameRole that is Qt::DecorationRole I think this change makes sense.

blaws added a comment.Nov 11 2018, 7:24 PM

Yeah, it seems most qton their github apps give it a name aswell

broulik accepted this revision.Nov 11 2018, 7:25 PM
This revision is now accepted and ready to land.Nov 11 2018, 7:25 PM
This revision was automatically updated to reflect the committed changes.