[SMS App] Don't set font size, which causes warnings to be printed
ClosedPublic

Authored by sredman on Nov 9 2018, 12:45 AM.

Details

Summary

Whenever a ConversationMessage was constructed, a warning was printed saying "Both point size and pixel size set. Using pixel size." Stop double-setting the font size and the warnings stop

This may be system-specific because I don't see where we are setting the font's point size. I will test this on a few different systems (I haven't yet) and I hope others will test it on their system!

Note that this is easiest to test when applied on top of D15979 so you can scroll up to cause more messages to be constructed

Test Plan

Before patch: Experience many warnings when using the SMS app
After patch: Experience fewer (0?) warnings when using the SMS app

Diff Detail

Repository
R224 KDE Connect
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sredman created this revision.Nov 9 2018, 12:45 AM
Restricted Application added a project: KDE Connect. · View Herald TranscriptNov 9 2018, 12:45 AM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
sredman requested review of this revision.Nov 9 2018, 12:45 AM
apol accepted this revision.Nov 9 2018, 12:54 AM
This revision is now accepted and ready to land.Nov 9 2018, 12:54 AM
This revision was automatically updated to reflect the committed changes.

Tested successfully on Manjaro and Neon, so presumably good