Differential D16725

Export account attribute 'VatRate' into a template file and read out again when importing
ClosedPublic
Actions

Authored by habacker on Nov 7 2018, 9:23 AM.

Details

Reviewers
tbaumgart
wojnilowicz
Commits
R261:6bb09a535ed9: Export account attribute 'VatRate' into a template file and read out again when…
R261:757f42ff80a7: Export account attribute 'VatRate' into a template file and read out again when…
Summary

CCBUG:380286

Test Plan

see https://bugs.kde.org/show_bug.cgi?id=380286#c13

Diff Detail

Repository
R261 KMyMoney
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
habacker requested review of this revision.Nov 7 2018, 9:23 AM
habacker created this revision.
wojnilowicz resigned from this revision.Nov 11 2018, 6:39 AM

I'm not familiar with that part of code. If you know what you're doing then please go for it.

This revision was not accepted when it landed; it landed in state Needs Review.Nov 16 2018, 11:07 AM
Closed by commit R261:6bb09a535ed9: Export account attribute 'VatRate' into a template file and read out again when… (authored by habacker). · Explain Why
This revision was automatically updated to reflect the committed changes.
habacker reopened this revision.Nov 16 2018, 11:18 AM
habacker updated this revision to Diff 45580.Nov 16 2018, 11:20 AM
  • rebased
habacker updated this revision to Diff 45582.Nov 16 2018, 11:48 AM
habacker edited the test plan for this revision. (Show Details)
  • add test plan
tbaumgart requested changes to this revision.Nov 24 2018, 10:32 AM
tbaumgart added inline comments.
kmymoney/converter/mymoneytemplate.cpp
319–321

Using toLatin1() does not make sense here. setValue() needs a const QString& which is satisfied by value directly. I agree, this might be a leftover from old code.

321

No need for the .latin1() here as well.

This revision now requires changes to proceed.Nov 24 2018, 10:32 AM
habacker updated this revision to Diff 46187.Nov 25 2018, 9:43 AM
  • remove call to .latin1()
habacker marked 2 inline comments as done.Nov 25 2018, 9:44 AM
tbaumgart accepted this revision.Nov 25 2018, 7:32 PM
This revision is now accepted and ready to land.Nov 25 2018, 7:32 PM
Closed by commit R261:757f42ff80a7: Export account attribute 'VatRate' into a template file and read out again when… (authored by habacker). · Explain WhyNov 26 2018, 8:58 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 46243

View Options

kmymoney/converter/mymoneytemplate.cpp

Loading...