Differential D16718

Add dependency for Qt Quick Controls 2
ClosedPublic
Actions

Authored by sredman on Nov 6 2018, 8:43 PM.

Details

Reviewers
apol
Group Reviewers
KDE Connect
Commits
R224:b0e9cb3c7c14: Add dependency for Qt Quick Controls 2
Summary

The app requires having Qt Quick Controls installed to launch

Test Plan
  • Attempt to launch app without Qt Quick Controls 2 package installed
  • App should complain and not appear
  • Attempt to launch app with Qt Quick Controls 2
  • App should launch and display properly

Diff Detail

Repository
R224 KDE Connect
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sredman created this revision.Nov 6 2018, 8:43 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptNov 6 2018, 8:43 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
sredman requested review of this revision.Nov 6 2018, 8:43 PM
sredman added a comment.Nov 6 2018, 8:44 PM

This is not exactly a build dependency. Should it be set TYPE RUNTIME?

apol added a subscriber: apol.Nov 7 2018, 12:06 AM

You can do it with Kirigami. Kirigami depends on QQC2 already.
And yes, it's a runtime dependency, so don't search for it as REQUIRED or packagers will be mad at you.

sredman updated this revision to Diff 45002.Nov 7 2018, 3:26 AM
  • Depend on Kirigami
apol accepted this revision.Nov 7 2018, 12:09 PM
apol added inline comments.
CMakeLists.txt
92

Maybe this URL is better: https://www.kde.org/products/kirigami/

This revision is now accepted and ready to land.Nov 7 2018, 12:09 PM
sredman updated this revision to Diff 45060.Nov 7 2018, 4:59 PM
  • Change Kirigami URL
Closed by commit R224:b0e9cb3c7c14: Add dependency for Qt Quick Controls 2 (authored by sredman). · Explain WhyNov 7 2018, 4:59 PM
This revision was automatically updated to reflect the committed changes.
sredman marked an inline comment as done.Nov 7 2018, 5:00 PM

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (9 lines)

Diff 45061

View Options

CMakeLists.txt

Loading...