Differential D16707

When creating sharePendingIntent use a unique requestCode so a new PendingIntent is created
ClosedPublic
Actions

Authored by eduisters on Nov 6 2018, 1:39 PM.

Details

Reviewers
albertvaka
Group Reviewers
KDE Connect
Commits
R225:b4853508e045: When creating sharePendingIntent use a unique requestCode so a new…
Summary

Fixes the situation where when 2 or more files are send to Android clicking the share button
in either of the notifications will always share the last received file.

BUG: 396051

Test Plan

Send 2 files to android
Click on the share button of the first received file

The first file is actually used for the share and not the last received file

Diff Detail

Repository
R225 KDE Connect - Android application
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
eduisters created this revision.Nov 6 2018, 1:39 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptNov 6 2018, 1:39 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
eduisters requested review of this revision.Nov 6 2018, 1:39 PM
albertvaka accepted this revision.Nov 6 2018, 3:41 PM
albertvaka added a subscriber: albertvaka.

Wow, certainly a bug. Thanks!

This revision is now accepted and ready to land.Nov 6 2018, 3:41 PM
Closed by commit R225:b4853508e045: When creating sharePendingIntent use a unique requestCode so a new… (authored by eduisters, committed by albertvaka). · Explain WhyNov 6 2018, 8:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 44988

View Options

src/org/kde/kdeconnect/Plugins/SharePlugin/ShareNotification.java

Loading...