Add branch and project information to package metadata.

Authored by knauss on Nov 6 2018, 12:07 PM.

Diff Detail

R857 CI System Tooling
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
knauss requested review of this revision.Nov 6 2018, 12:07 PM
knauss created this revision.
bcooksley added inline comments.Nov 7 2018, 9:05 AM

This won't work in a Jenkins context, because it checks out the explicit revision it has determined needs to be built.
The branch itself isn't checked out.

I'd suggest making use of the --branchGroup parameter which is used by the other CI tools (and should be more reliable, because even if we've moved from 6.0 to 6.1 as the library version, if the SONAME hasn't changed, we still need to keep ABI compatibility)

knauss added inline comments.Nov 7 2018, 9:33 AM

Well the branch information is now only needed for cases, we see a newer SONAME. E.g. you have a stable build for 18.08 with SONAME 5 and on master there is SONAME 6 and we want to supress the error, that we found a newer SONAME.
We can also use branchGroup for this.

bcooksley added inline comments.Nov 7 2018, 9:37 AM

branchGroup should be perfectly fine to use for that, as a given branch group usually only moves forward in version number (5.2 to 5.3 for stable for instance) or on the same branch (master stays as master)

knauss updated this revision to Diff 45105.Nov 8 2018, 9:48 AM
knauss marked 3 inline comments as done.

use branchGroup instead of git branch.

bcooksley accepted this revision.Nov 9 2018, 7:00 AM

Perfect. Will land this shortly.

This revision is now accepted and ready to land.Nov 9 2018, 7:00 AM
This revision was automatically updated to reflect the committed changes.