Details
- Reviewers
bcooksley - Maniphest Tasks
- T3689: Add abi compliance checker to CI
- Commits
- R857:b4f67c959f67: Add branch and project information to package metadata for ABI dumps
Diff Detail
- Repository
- R857 CI System Tooling
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 4710 Build 4728: arc lint + arc unit
helpers/create-abi-dump.py | ||
---|---|---|
291 | This won't work in a Jenkins context, because it checks out the explicit revision it has determined needs to be built. I'd suggest making use of the --branchGroup parameter which is used by the other CI tools (and should be more reliable, because even if we've moved from 6.0 to 6.1 as the library version, if the SONAME hasn't changed, we still need to keep ABI compatibility) |
helpers/create-abi-dump.py | ||
---|---|---|
291 | Well the branch information is now only needed for cases, we see a newer SONAME. E.g. you have a stable build for 18.08 with SONAME 5 and on master there is SONAME 6 and we want to supress the error, that we found a newer SONAME. |
helpers/create-abi-dump.py | ||
---|---|---|
291 | branchGroup should be perfectly fine to use for that, as a given branch group usually only moves forward in version number (5.2 to 5.3 for stable for instance) or on the same branch (master stays as master) |