Differential D16696

Add support for sharing text from plasmoid
ClosedPublic
Actions

Authored by blaws on Nov 5 2018, 7:35 PM.

Details

Reviewers
albertvaka
Group Reviewers
VDG
KDE Connect
Commits
R224:061d415f83ac: Add support for sharing text from plasmoid
Summary

This allows you to enter text in the plasmoid and it be sent
to the connected device.

Diff Detail

Repository
R224 KDE Connect
Branch
share-text-qml (branched from master)
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 4686
Build 4704: arc lint + arc unit
blaws created this revision.Nov 5 2018, 7:35 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptNov 5 2018, 7:35 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
blaws requested review of this revision.Nov 5 2018, 7:35 PM
apol added a subscriber: apol.Nov 7 2018, 12:08 AM

Can you show a screenshot?

plasmoid/package/contents/ui/DeviceDelegate.qml
332 ↗(On Diff #44933)

Clip shouldn't be necessary.

blaws added a comment.Nov 7 2018, 4:46 PM

here is an image

blaws updated this revision to Diff 45057.Nov 7 2018, 4:49 PM

Removed commented text
Remove unneeded clip: true

blaws marked an inline comment as done.Nov 7 2018, 4:49 PM
albertvaka accepted this revision.Nov 7 2018, 6:22 PM
This revision is now accepted and ready to land.Nov 7 2018, 6:22 PM
Closed by commit R224:061d415f83ac: Add support for sharing text from plasmoid (authored by blaws). · Explain WhyNov 7 2018, 9:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 45057

View Options

plasmoid/package/contents/ui/DeviceDelegate.qml

Loading...