Differential D1669

Introduce arkviewer.ui
ClosedPublic
Actions

Authored by elvisangelaccio on May 24 2016, 9:32 AM.

Details

Reviewers

rthomsen

Commits

R36:ed39617835da: Introduce arkviewer.ui

Summary

This patch simplifies ArkViewer by moving its UI code to arkviewer.ui

The only thing I did not move was the label with the name of the temp extracted
file (e.g. /tmp/ark-Woufd4f3f). I'm not sure whether the average user is
interested to see this random pathname...

Test Plan

Just make sure that the size of the preview dialog is preserved.

Diff Detail

Repository

R36 Ark

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

elvisangelaccio updated this revision to Diff 3959.May 24 2016, 9:32 AM

elvisangelaccio retitled this revision from to Introduce arkviewer.ui.

elvisangelaccio updated this object.

elvisangelaccio edited the test plan for this revision. (Show Details)

elvisangelaccio added a reviewer: rthomsen.

Restricted Application added a project: Ark. · View Herald TranscriptMay 24 2016, 9:32 AM

Restricted Application added a subscriber: kde-utils-devel. · View Herald Transcript

Ship i! :)

This revision is now accepted and ready to land.May 27 2016, 9:27 PM

Closed by commit R36:ed39617835da: Introduce arkviewer.ui (authored by elvisangelaccio). · Explain WhyMay 28 2016, 5:15 PM

This revision was automatically updated to reflect the committed changes.

elvisangelaccio mentioned this in R36:ed39617835da: Introduce arkviewer.ui.

Revision Contents
Changeset List

		Path
M		part/CMakeLists.txt (6 lines)
M		part/arkviewer.h (7 lines)
M		part/arkviewer.cpp (51 lines)
A	M	part/arkviewer.ui (106 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	3959	0c8e5af		May 24 2016, 9:32 AM	★	★
Diff 2	4033	04a6386	rARKed39617835da0933971e17dbe956127c79f3219b	May 28 2016, 5:09 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
324b76f205c1	0ffd67aefe8e	fbd0f9b7c00b 0c8e5af5cb68	Elvis Angelaccio	Merge branch 'master' into refactor/arkviewer	May 24 2016, 9:13 AM
fbd0f9b7c00b	a867ca75e0ba	0c7dfb249841	Elvis Angelaccio	parent--	May 24 2016, 9:11 AM
0c7dfb249841	b60991a41746	271fb8a1497f	Elvis Angelaccio	cleanup	Apr 14 2016, 3:16 PM
271fb8a1497f	26cb61ec14bd	a9ca17bf3b26	Elvis Angelaccio	Use placeholder for part widget	Apr 14 2016, 3:00 PM
a9ca17bf3b26	70372eaa3ae4	a16652d8e383	Elvis Angelaccio	nullptr++	Apr 14 2016, 11:10 AM
a16652d8e383	4a08fd8de9af	d55f1ba3e368	Elvis Angelaccio	Fix size	Apr 14 2016, 11:05 AM
d55f1ba3e368	12bffa70f23b	4d5afd421c88	Elvis Angelaccio	Fix size policy	Apr 14 2016, 10:44 AM
4d5afd421c88	687a5a2d9651	95c933b85035	Elvis Angelaccio	Fix dialog title	Apr 14 2016, 10:13 AM
95c933b85035	ad8478f3c153	02d26d42d5bf	Elvis Angelaccio	Introduce arkviewer.ui	Apr 14 2016, 10:06 AM