Differential D1668

Add the Device to the input event summary
ClosedPublic
Actions

Authored by graesslin on May 24 2016, 9:06 AM.

Details

Reviewers
sebas
Group Reviewers
Plasma
Commits
R108:5f2245adaf8c: Add the Device to the input event summary
Summary

Now that we have access to the actual LibInput Device from the event
handler, let's also print out which device received an event.

Test Plan

Manual testing whether the correct device is shown

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 3957.May 24 2016, 9:06 AM
graesslin retitled this revision from to Add the Device to the input event summary.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptMay 24 2016, 9:06 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sebas accepted this revision.May 26 2016, 12:44 PM
sebas added a reviewer: sebas.
sebas added a subscriber: sebas.
sebas added inline comments.
debug_console.cpp
135 ↗(On Diff #3957)

input device *of* this event ?

147 ↗(On Diff #3957)

also gets appended to the last element, so we end up with a trailing space

This revision is now accepted and ready to land.May 26 2016, 12:44 PM
graesslin added inline comments.May 30 2016, 6:11 AM
debug_console.cpp
147 ↗(On Diff #3957)

I'll change the

return ret;

to

return ret.trimmed();
graesslin marked an inline comment as done.May 30 2016, 6:47 AM
graesslin marked 2 inline comments as done.May 30 2016, 1:31 PM
Closed by commit R108:5f2245adaf8c: Add the Device to the input event summary (authored by graesslin). · Explain WhyMay 30 2016, 1:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mdebug_console.cpp (26 lines)

Diff 4071

View Options

debug_console.cpp

Loading...