Differential D16660

Preserve double/triple click mode when extending the selection
ClosedPublic
Actions

Authored by glenncoombs on Nov 4 2018, 11:05 AM.

Details

Reviewers
hindenburg
Group Reviewers
Konsole
Commits
R319:f508ed8632f6: Preserve double/triple click mode when extending the selection
R319:e2167eb0674e: Preserve double/triple click mode when extending the selection
Summary

When extending the selection using the mouse the double or triple click
mode that initiated the selection should be preserved. If the user double
clicked to select a word, then extending the selection should extend
"word at a time" rather than "character at a time". Similarly if the user
triple clicked to select a whole line initially, then extending the selection
should extend "line at a time" rather than "character at a time".

BUG: 374454
FIXED-IN: 18.12

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
glenncoombs requested review of this revision.Nov 4 2018, 11:05 AM
glenncoombs created this revision.
hindenburg added a comment.Nov 7 2018, 1:48 AM

OK that's nice - thanks. If you can, use arc to upload diffs and it adds your name and email. I can still fix that if you provide your name and email address.

https://community.kde.org/Infrastructure/Phabricator

glenncoombs added a comment.Nov 7 2018, 2:04 PM

Okay, I'll install arc and see if I can get that working.

Glenn

hindenburg added a comment.Nov 7 2018, 2:30 PM

For this one you can provide your name/email and I'll fix the commit

hindenburg added a comment.Nov 10 2018, 1:33 AM

18.12 is split off - I can commit if you provide email

glenncoombs added a comment.Nov 11 2018, 10:39 AM

Okay, my name is Glenn Coombs and my email address is glenn.coombs@gmail.com.

hindenburg accepted this revision.Nov 11 2018, 3:03 PM
hindenburg edited the summary of this revision. (Show Details)

Thanks

This revision is now accepted and ready to land.Nov 11 2018, 3:05 PM
Closed by commit R319:f508ed8632f6: Preserve double/triple click mode when extending the selection (authored by glenncoombs, committed by hindenburg). · Explain WhyNov 11 2018, 3:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/TerminalDisplay.cpp (6 lines)

Diff 45293

View Options

src/TerminalDisplay.cpp

Loading...