[handler] Embed URL into string
ClosedPublic
Actions

Authored by nicolasfella on Nov 3 2018, 12:04 AM.

Details

Reviewers

apol

Group Reviewers

KDE Connect

Commits

R224:193481ce468d: [handler] Embed URL into string

Summary

E.g.
Device to call +1234567 with
Device to send /home/nico/foo to
Device to open http://google.com on

Repository

R224 KDE Connect

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kdeconnect. · View Herald Transcript

nicolasfella requested review of this revision.Nov 3 2018, 12:04 AM

nicolasfella edited the summary of this revision. (Show Details)

apol added a subscriber: apol.

apol added inline comments.

urlhandler/kdeconnect-handler.cpp
102–103	It doesn't make a lot of sense to PreferLocalFile when we know !isLocalFile

This revision is now accepted and ready to land.Nov 3 2018, 12:14 AM

urlhandler/kdeconnect-handler.cpp
102–103	It will make sense later, I promise ;)

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			urlhandler/dialog.ui (7 lines)
M			urlhandler/kdeconnect-handler.cpp (17 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	44741	357751a		Nov 3 2018, 12:04 AM	★	★
Diff 2	44744	357751a	R224:193481ce468deab888f9915da25d7789d1d2531d	Nov 3 2018, 12:37 AM	★	★