Hmm, technically those methods (slots) are accessed from another class, so they /should/ be public or, preferably, the connect statements should be in the Private class. Also, you can probably now remove the Q_PRIVATE_SLOT declarations form IncidenceTreeModel header file.

mlaurent requested changes to this revision.Nov 1 2018, 12:41 PM

mlaurent added a subscriber: mlaurent.

mlaurent added inline comments.

src/todo/todoview.cpp
208–209	QOverload<....>

This revision now requires changes to proceed.Nov 1 2018, 12:41 PM

Moving connect and disconnect to the private class

Harbormaster completed remote builds in B4443: Diff 44650.Nov 1 2018, 4:23 PM

dvratil accepted this revision.Nov 1 2018, 5:19 PM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 1 2018, 5:25 PM

Closed by commit R76:04d78daf8b33: Replace old connect with QT5 style in eventsview (Part 1) (authored by ognarb). · Explain Why

This revision was automatically updated to reflect the committed changes.

ognarb marked an inline comment as done.

			Path	Packages
M			src/todo/incidencetreemodel.cpp (160 lines)
M			src/todo/incidencetreemodel_p.h (3 lines)
M			src/todo/todoview.cpp (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	44620	4fde767		Nov 1 2018, 10:55 AM	★	★
Diff 2	44626	4fde767	Use friend class instead of making slots public	Nov 1 2018, 11:57 AM	★	★
Diff 3	44627	4fde767	Add todoviewsortfilterproxymodel	Nov 1 2018, 12:04 PM	★	★
Diff 4	44650	4fde767	Moving connect and disconnect to the private class	Nov 1 2018, 4:23 PM	★	★
Diff 5	44653	a7591aa	R76:04d78daf8b33979ce68f359d4e9fe4487198022a	Nov 1 2018, 5:24 PM	★	★

Replace old connect with QT5 style in eventsview (Part 1)
ClosedPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 44653

src/todo/incidencetreemodel.cpp

src/todo/incidencetreemodel_p.h

src/todo/todoview.cpp

Replace old connect with QT5 style in eventsview (Part 1)ClosedPublicActions