[KCMs] move GHNS buttons to the normal location
ClosedPublic
Actions

Authored by ngraham on Oct 31 2018, 4:56 AM.

Details

Reviewers

Group Reviewers

KWin
VDG

Maniphest Tasks

T9954: GHNS buttons should be in the bottom-right corner of the KCM window

Commits

R108:9a59e3fb6cf4: [KCMs] move GHNS buttons to the normal location

Summary

All other KCMs have their Get New [things]... buttons in the bottom-right corner. This patch adjusts KWin's KCMs to adopt the same convention there too.

With this patch, all KCMs will have their GHNS buttons in the same location.

Closes T9954

Test Plan

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

ngraham created this revision.Oct 31 2018, 4:56 AM

Restricted Application added projects: KWin, Documentation. · View Herald TranscriptOct 31 2018, 4:56 AM

Restricted Application added subscribers: kde-doc-english, kwin. · View Herald Transcript

ngraham requested review of this revision.Oct 31 2018, 4:56 AM

Harbormaster completed remote builds in B4356: Diff 44525.Oct 31 2018, 4:56 AM

ngraham edited the test plan for this revision. (Show Details)Oct 31 2018, 4:56 AM

zzag accepted this revision.Oct 31 2018, 8:26 AM

This revision is now accepted and ready to land.Oct 31 2018, 8:26 AM

Good work
Seems more better

Closed by commit R108:9a59e3fb6cf4: [KCMs] move GHNS buttons to the normal location (authored by ngraham). · Explain WhyOct 31 2018, 1:30 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			doc/kwindecoration/index.docbook (2 lines)
M			kcmkwin/kwincompositing/qml/EffectView.qml (20 lines)
M			kcmkwin/kwindecoration/kcm.ui (46 lines)
M			kcmkwin/kwinscripts/module.ui (91 lines)
M			kcmkwin/kwintabbox/main.cpp (17 lines)
M			kcmkwin/kwintabbox/main.ui (20 lines)