Differential D1652

Remove moveCompletionPopup() hack.
ClosedPublic
Actions

Authored by dfaure on May 21 2016, 10:05 AM.

Details

Reviewers
mlaurent
Commits
R89:f00442dbe21f: Remove moveCompletionPopup() hack.
Summary
  1. commit b78a77e95659 in kdelibs 4.9.2 (see bug 270473) takes

care of making KCompletionBox move/resize when the parent widget has moved/resized.

  1. this hack made the completion popup not appear for me, the very first time.

After hide()+show(), isVisible() was true, but the popup wasn't actually visible
(geometry was correct though). Possibly a Qt issue, but that's what we get when
doing hacks.

Test Plan

Ctrl+N, @, no popup appears. And this breaks the Tab key since the code thinks it's visible...

Question: is such a BIC change OK or do I need to keep and deprecate the virtual method?

Diff Detail

Repository
R89 PIM: Libraries
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dfaure updated this revision to Diff 3916.May 21 2016, 10:05 AM
dfaure retitled this revision from to Remove moveCompletionPopup() hack..
dfaure updated this object.
dfaure edited the test plan for this revision. (Show Details)
Restricted Application added a project: KDE PIM. · View Herald TranscriptMay 21 2016, 10:05 AM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
mlaurent accepted this revision.May 21 2016, 12:43 PM
mlaurent edited edge metadata.

"Question: is such a BIC change OK or do I need to keep and deprecate the virtual method?" you can break BC no problem.

+2

This revision is now accepted and ready to land.May 21 2016, 12:43 PM
Closed by commit R89:f00442dbe21f: Remove moveCompletionPopup() hack. (authored by dfaure). · Explain WhyMay 21 2016, 8:23 PM
This revision was automatically updated to reflect the committed changes.
winterz added a subscriber: winterz.May 21 2016, 9:08 PM

David,

Can you also check incidenceeditor/src/attendeeline.h and messagelib/messagecomposer/src/recipient/recipientline.h both of which have overrides for moveCompletionPopup().. it could be we simply remove the Q_DECL_OVERRIDE for both of those, or it could be something more drastic needs to be done.

dfaure added a comment.May 21 2016, 9:21 PM

I committed recipientlineeditor together with this, but indeed I didn't know about incidenceeditor - done now, thanks for the note.

Revision Contents
Changeset List

Diff 3921

View Options

src/multiplyingline/multiplyingline.h

Loading...
View Options

src/multiplyingline/multiplyinglineview_p.h

Loading...
View Options

src/multiplyingline/multiplyinglineview_p.cpp

Loading...