Differential D16501

[remoteinput] Added keyboard support for windows
ClosedPublic
Actions

Authored by jambon on Oct 29 2018, 2:56 AM.

Details

Reviewers
albertvaka
Group Reviewers
KDE Connect
Commits
R224:467ac64be7d1: [remoteinput] Added keyboard support for windows
Summary

Added keyboard input support for Windows
Completes T6269

Test Plan
  • Open Remote input
  • Type something in

Diff Detail

Repository
R224 KDE Connect
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jambon created this revision.Oct 29 2018, 2:56 AM
Restricted Application added a subscriber: kdeconnect. · View Herald TranscriptOct 29 2018, 2:56 AM
jambon requested review of this revision.Oct 29 2018, 2:56 AM
jambon edited the summary of this revision. (Show Details)Oct 29 2018, 3:00 AM
jambon added reviewers: albertvaka, nicolasfella.
albertvaka accepted this revision.Oct 29 2018, 1:48 PM
albertvaka added a subscriber: albertvaka.

Thanks for the patch!

Just tried it, and it works great. Some shortcuts don't seem to be recognized, though: I can't do ctrl+c or ctrl+v but ctrl+tab seems to work. I'm using Hacker's keyboard on Android to enter special keys.

Apart from that, text input works 100%, so I think we can merge this anyway and fix it later (unless you want to update this patch with the fix). I will need your email to merge the patch in your behalf.

This revision is now accepted and ready to land.Oct 29 2018, 1:48 PM
jambon added a comment.Oct 29 2018, 8:42 PM

I think I know the reason why ctrl+c or ctrl+v doesn't work. It's because when KEYEVENTF_UNICODE is used, a VK_PACKET keystroke is sent which doesn't combine with other keys. I'll try to update the patch with a fix this week.

jambon updated this revision to Diff 44471.Oct 29 2018, 11:39 PM

Fixed key combinations. This patch is ready to be merged.
My email is jambonmcyeah@gmail.com.

P.S. Thank you guys for creating such a wonderful app. I'm glad I could contribute.

jambon updated this revision to Diff 44478.Oct 30 2018, 3:15 AM
jambon updated this revision to Diff 44479.Oct 30 2018, 3:58 AM
Closed by commit R224:467ac64be7d1: [remoteinput] Added keyboard support for windows (authored by jambon, committed by albertvaka). · Explain WhyOct 30 2018, 10:34 AM
This revision was automatically updated to reflect the committed changes.
albertvaka added a comment.Oct 30 2018, 10:35 AM

Awesome! Landing patch :)

albertvaka added a comment.Oct 30 2018, 10:39 AM

By the way, feel free to join the KDE Connect development Telegram group https://t.me/joinchat/AOS6gA37orb2dZCLhqbZjg or the IRC channel #kdeconnect (both are bridged together), specially if you plan on contributing more patches! More help with the Windows stuff would be great, actually :)

nicolasfella added a subscriber: nicolasfella.Oct 30 2018, 11:47 AM

If you are looking for something to do next, the RunCommand Plugin should be fairly easy to port to Windows. Just replace the "/bin/sh" command with something appropriate for Windows

Revision Contents
Changeset List

Diff 44484

View Options

plugins/mousepad/windowsremoteinput.cpp

Loading...