Differential D16496

Fix a bug created in D16377
ClosedPublic
Actions

Authored by ognarb on Oct 28 2018, 9:24 PM.

Details

Reviewers
mlaurent
Group Reviewers
KDE PIM
Commits
R76:4fde767087d7: Fix a bug created in D16377
Summary

Look likes I did something wrong in D16377 with the line in the agenda. I forgot a '!' in an expression and didn't apply correct grey scale for the line.

Test Plan

Tested with breeze, breeze dark, arc dark and oxygen

arc dark:


breeze:

breeze dark:

oxygen:

Diff Detail

Repository
R76 PIM: Event Views
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4287
Build 4305: arc lint + arc unit
ognarb created this revision.Oct 28 2018, 9:24 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptOct 28 2018, 9:24 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
ognarb requested review of this revision.Oct 28 2018, 9:24 PM
ognarb updated this revision to Diff 44386.Oct 28 2018, 9:27 PM

Use windowTextColor instead of palette().color(QPalette::WindowText)

ognarb added reviewers: KDE PIM, mlaurent.Oct 28 2018, 9:27 PM
ognarb edited the test plan for this revision. (Show Details)
mlaurent added a comment.Oct 29 2018, 5:53 AM

Screenshot please :)

ognarb edited the test plan for this revision. (Show Details)Oct 29 2018, 2:41 PM
In D16496#350253, @mlaurent wrote:

Screenshot please :)

I updated the description :)

mlaurent accepted this revision.Oct 30 2018, 5:58 AM

it seems ok.
Thanks

This revision is now accepted and ready to land.Oct 30 2018, 5:58 AM
Closed by commit R76:4fde767087d7: Fix a bug created in D16377 (authored by ognarb). · Explain WhyOct 30 2018, 7:55 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/agenda/agenda.cpp (15 lines)

Diff 44386

View Options

src/agenda/agenda.cpp

Loading...