Differential D16437

Fix include guards
ClosedPublic
Actions

Authored by sredman on Oct 26 2018, 4:17 PM.

Details

Reviewers
nicolasfella
Group Reviewers
KDE Connect
Commits
R224:b01652f54d78: Fix include guards
Summary

Some plugins were copy/pasted from a template and forgot to change their include guards. Since plugin header files are never cross-referenced, this was not a serious issue, but it looks nicer to be correct

NotificationListener.h did not have an include guard. As before, this is not a problem currently, but it's best to have it fixed

Test Plan

Project should build, compile, and run as normal

Diff Detail

Repository
R224 KDE Connect
Branch
master
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 4213
Build 4231: arc lint + arc unit
sredman created this revision.Oct 26 2018, 4:17 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptOct 26 2018, 4:17 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
sredman requested review of this revision.Oct 26 2018, 4:17 PM
sredman updated this revision to Diff 44256.Oct 26 2018, 4:22 PM

Add missing include guard

sredman retitled this revision from De-duplicate include guards to Fix include guards.Oct 26 2018, 4:23 PM
sredman edited the summary of this revision. (Show Details)
nicolasfella accepted this revision.Oct 26 2018, 8:16 PM
This revision is now accepted and ready to land.Oct 26 2018, 8:16 PM
sredman closed this revision.Oct 26 2018, 9:29 PM

Showing Only Differences

This revision modifies 2 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Diff 44256

View Options

plugins/sendnotifications/notificationslistener.h

Loading...