Differential D16414

Changes to REXX syntax highlighting
ClosedPublic
Actions

Authored by phily on Oct 24 2018, 8:22 PM.

Details

Reviewers
cullmann
Group Reviewers
Framework: Syntax Highlighting
Summary

The rexx syntax highlighting was incomplete. It was missing keywords, sub keywords and control flow keywords.

Diff Detail

Repository
R216 Syntax Highlighting
Lint
Lint Skipped
Unit
Unit Tests Skipped
phily created this revision.Oct 24 2018, 8:22 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptOct 24 2018, 8:22 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
phily requested review of this revision.Oct 24 2018, 8:22 PM
cullmann requested changes to this revision.Oct 25 2018, 6:41 PM
cullmann added a subscriber: cullmann.

Hi, nice that you take care of fixing these issues.

Two small things that could be improved:

  1. the version="2" needs to be bumped to 3
  2. there should be some unit test for the highlighting, you can put some test file into autotests/input (e.g. test.rex) this will make it much easier to keep this in a OK state in the future

If you need more pointers on the testing, just ping us here, thanks!

This revision now requires changes to proceed.Oct 25 2018, 6:41 PM
phily updated this revision to Diff 44281.Oct 27 2018, 6:34 AM

Added test file to autotests/input/test.rexx as well as upgrading the version number

phily updated this revision to Diff 44282.Oct 27 2018, 6:38 AM

Did not include the syntax file itself in my last update, now the diff includes both.

phily updated this revision to Diff 44283.Oct 27 2018, 7:03 AM

Removed typo in test script

cullmann accepted this revision.Oct 27 2018, 2:38 PM

Thanks for the test file, I fixed the no longer existing ref

<keyword attribute="Instructions" context="#stay" String="instructions" />

and pushed the stuff!

This revision is now accepted and ready to land.Oct 27 2018, 2:38 PM
cullmann closed this revision.Oct 27 2018, 2:39 PM

Hmpf, arc failed :/

But the stuff is in at least:

Git commit e07306d9c22f6426d6b50287eee532555d74ac75 by Christoph Cullmann.
Committed on 27/10/2018 at 14:36.
Pushed by cullmann into branch 'master'.

add test file + remove no longer existing instructions reference from xml

A +52 -0 autotests/folding/test.rexx.fold
A +59 -0 autotests/html/test.rexx.html
A +52 -0 autotests/input/test.rexx
A +52 -0 autotests/reference/test.rexx.ref
M +158 -93 data/syntax/rexx.xml

https://commits.kde.org/syntax-highlighting/e07306d9c22f6426d6b50287eee532555d74ac75

Revision Contents
Changeset List

PathPackages
Mautotests/input/test.rexx (52 lines)
Mdata/syntax/rexx.xml (250 lines)

Diff 44281

View Options

autotests/input/test.rexx

Loading...
View Options

data/syntax/rexx.xml

Loading...