fix warnings
ClosedPublic
Actions

Authored by apol on Oct 22 2018, 3:56 PM.

Details

Reviewers

mart

Group Reviewers

Kirigami

Commits

R169:96aa888815d1: fix warnings

Summary

Don't call directly properties that may be undefined

Test Plan

Now discover still works without warnings in the GlobalDrawer

Repository

R169 Kirigami

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

apol requested review of this revision.Oct 22 2018, 3:56 PM

This revision is now accepted and ready to land.Oct 30 2018, 3:00 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/controls/GlobalDrawer.qml (7 lines)
M			src/controls/private/BannerImage.qml (6 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	44077	3a7782e		Oct 22 2018, 3:55 PM	★	★
Diff 2	44497	c4e3910	R169:96aa888815d12fb18463ae35a0c3c4946e333930	Oct 30 2018, 3:45 PM	★	★