Differential D16358

[effects/invert] Don't block blur and background contrast effect
ClosedPublic
Actions

Authored by zzag on Oct 21 2018, 6:30 PM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Commits
R108:9fae2f4905d5: [effects/invert] Don't block blur and background contrast effect
Summary

Background behind some windows is not blurred because the invert effect
sets PAINT_WINDOW_TRANSFORMED. This essentially "turns off" the blur and
the background contrast effect unless we set the force roles.

Because the invert effect is a "post-processing"(not really) effect we
don't have to set that flag.

BUG: 279076
BUG: 359583
FIXED-IN: 5.14.3

Test Plan

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Oct 21 2018, 6:30 PM
Restricted Application added a project: KWin. · View Herald TranscriptOct 21 2018, 6:30 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Oct 21 2018, 6:30 PM
zzag edited the summary of this revision. (Show Details)Oct 23 2018, 7:45 AM
davidedmundson accepted this revision.Oct 23 2018, 10:18 AM
This revision is now accepted and ready to land.Oct 23 2018, 10:18 AM
Closed by commit R108:9fae2f4905d5: [effects/invert] Don't block blur and background contrast effect (authored by zzag). · Explain WhyOct 23 2018, 1:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Meffects/invert/invert.h (9 lines)
Meffects/invert/invert.cpp (13 lines)

Diff 44107

View Options

effects/invert/invert.h

Loading...
View Options

effects/invert/invert.cpp

Loading...