[Kickoff/Trash] Offer KCM access only if allowed
ClosedPublic

Authored by broulik on May 18 2016, 6:01 PM.

Details

Summary

Remove the context menus that would do nothing if access to those KCMs is restricted.
Don't indicate clickable area with pointy cursor for Kickoff user avatar if restricted.
Also fix trash desktop file name.

Test Plan

Added the respective KCM desktop file names to [KDE Control Module Restrictions]:

  • Didn't get a "Configure" entry for Trash
  • No more pointy finger on Kickoff user avatar

Confirmed that KCMShell refused to open and Dolphin / System Settings didn't list; still works when no restriction is set.
KTP applet, Printer Manager applet and potentially others would need to be adjusted still.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 3862.May 18 2016, 6:01 PM
broulik retitled this revision from to [Kickoff/Trash] Offer KCM access only if allowed.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma. · View Herald TranscriptMay 18 2016, 6:01 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik updated this revision to Diff 3863.May 18 2016, 6:01 PM

It's kcmtrash, not trash.

mart accepted this revision.May 19 2016, 2:28 PM
mart added a reviewer: mart.
This revision is now accepted and ready to land.May 19 2016, 2:28 PM
This revision was automatically updated to reflect the committed changes.