Differential D1622

[client] Ensure PlasmaWindowModel removes deleted windows
ClosedPublic
Actions

Authored by graesslin on May 17 2016, 7:32 AM.

Details

Reviewers
hein
Group Reviewers
Plasma
Commits
R127:f39f4bf99d66: [client] Ensure PlasmaWindowModel removes deleted windows
Summary

There is a possibility that a PlasmaWindow is unmapped when the
PlasmaWindowModel gets created. In this situation the unmapped
PlasmaWindow will be deleted in the next event cycle. So far
PlasmaWindowModel didn't handle this situation and the model might
hold deleted objects due to this.

This change addresses this potential problem and ensures the model
gets updated when a PlasmaWindow is deleted.

Test Plan

Test case which exposes the problem is added

Diff Detail

Repository
R127 KWayland
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 3832.May 17 2016, 7:32 AM
graesslin retitled this revision from to [client] Ensure PlasmaWindowModel removes deleted windows.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added reviewers: Plasma, hein.
Restricted Application added a project: Plasma. · View Herald TranscriptMay 17 2016, 7:32 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
hein accepted this revision.May 17 2016, 9:38 AM
hein edited edge metadata.
This revision is now accepted and ready to land.May 17 2016, 9:38 AM
Closed by commit R127:f39f4bf99d66: [client] Ensure PlasmaWindowModel removes deleted windows (authored by graesslin). · Explain WhyMay 17 2016, 11:13 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 3837

View Options

autotests/client/test_plasma_window_model.cpp

Loading...
View Options

src/client/plasmawindowmodel.cpp

Loading...