Instead of copying and clearing the file list, just move it
AbandonedPublic
Actions

Authored by bruns on Oct 12 2018, 8:31 PM.

Details

Reviewers

Group Reviewers

Baloo
Frameworks

Summary

This makes it more explicit the list of files is now owned by the
Indexer runnable.

Test Plan

make

Diff Detail

Repository

R293 Baloo

Branch

indexer_cleanup

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 3825
Build 3843: arc lint + arc unit

bruns created this revision.Oct 12 2018, 8:31 PM

Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptOct 12 2018, 8:31 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

bruns requested review of this revision.Oct 12 2018, 8:31 PM

Harbormaster completed remote builds in B3825: Diff 43509.Oct 12 2018, 8:31 PM

Does not work as wanted, as the compiler squeezes in a QStringList copy construction and the moves the temporary. Afterwards the temporary is empty(), but the filelist is not.

auto runnable = new NewFileIndexer(m_db, m_config, std::exchange(m_newFiles, {})); would work, but that is C++14

Revision Contents
Changeset List

			Path	Packages
M			src/file/fileindexscheduler.cpp (9 lines)
M			src/file/modifiedfileindexer.h (2 lines)
M			src/file/modifiedfileindexer.cpp (2 lines)
M			src/file/newfileindexer.h (2 lines)
M			src/file/newfileindexer.cpp (2 lines)
M			src/file/xattrindexer.h (2 lines)
M			src/file/xattrindexer.cpp (2 lines)