Revisit QtHelp Settings Dialog
ClosedPublic

Authored by cordlandwehr on May 15 2016, 1:25 PM.

Details

Summary
  1. Group all QtHelp autoloading in one group box
  1. Remove up/down move buttons

These buttons only have an effect to the order of th QtHelp files added
in the table view. Moreover, there are usually more help files installed
by e.g. the system's Qt API docs, files by the QtHelp search dir, and by
different providers like CMake help or PHP help. As a result, the user
can just order the subgroup of documentation files in the table while
the other files, as provided in the documentation widget combo box
cannot change order.

  1. Refactor duplicated code
  1. Move Table Controls into Table

Add remove/modify control buttons into the table to have a clean
separation between installation and modification of documentation
files.

  1. Update TODO about delete button

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cordlandwehr retitled this revision from to Revisit QtHelp Settings Dialog.
cordlandwehr edited the test plan for this revision. (Show Details)
cordlandwehr added a reviewer: KDevelop.
cordlandwehr updated this object.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptMay 15 2016, 1:25 PM
mwolff accepted this revision.May 24 2016, 8:56 PM
mwolff added a reviewer: mwolff.
mwolff added a subscriber: mwolff.

Could you try to move the wide buttons below the table? Now that you moved the other buttons into the table, I don't think we need to have the buttons on the side anymore. And since they are wide, they take away quite some space from the table. If they are below the table (or above, your choice), and next to each other, it should be even better I think!

otherwise: good improvement already

documentation/qthelp/qthelpconfig.cpp
414

QStringLiteral

422

QLatin1String

This revision is now accepted and ready to land.May 24 2016, 8:56 PM
This revision was automatically updated to reflect the committed changes.