Differential D16124

[kcmkwin/ruleswidget] Disable "Detect" button when countdown is running
ClosedPublic
Actions

Authored by broulik on Oct 11 2018, 8:12 AM.

Details

Reviewers
graesslin
Group Reviewers
KWin
Commits
R108:980e390743c1: [kcmkwin/ruleswidget] Disable "Detect" button when countdown is running
Summary

Avoids triggering an assert and communicates that the timeout is running.
Ideally, there was a countdown label of some sort but this is better than crashing.

BUG: 399644
FIXED-IN: 5.12.8

Test Plan
  • Set timeout, clicked button, button was disabled, choose window, clicked OK, button was enabled again

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Oct 11 2018, 8:12 AM
Restricted Application added a project: KWin. · View Herald TranscriptOct 11 2018, 8:12 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
broulik requested review of this revision.Oct 11 2018, 8:12 AM
graesslin accepted this revision.Oct 11 2018, 4:35 PM
This revision is now accepted and ready to land.Oct 11 2018, 4:35 PM
Closed by commit R108:980e390743c1: [kcmkwin/ruleswidget] Disable "Detect" button when countdown is running (authored by broulik). · Explain WhyOct 12 2018, 11:53 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkcmkwin/kwinrules/ruleswidget.cpp (2 lines)

Diff 43458

View Options

kcmkwin/kwinrules/ruleswidget.cpp

Loading...