Differential D16086

Patch .pri and .cmake files
ClosedPublic
Actions

Authored by vonreth on Oct 9 2018, 6:39 PM.

Tags

None

Subscribers

None

Details

Reviewers

bcooksley
kfunk

Commits

R138:93bb276c8932: Patch .pri and .cmake files

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

vonreth created this revision.Oct 9 2018, 6:39 PM

Harbormaster completed remote builds in B3696: Diff 43245.Oct 9 2018, 6:39 PM

vonreth requested review of this revision.Oct 9 2018, 6:39 PM

vonreth added reviewers: bcooksley, kfunk.Oct 9 2018, 6:40 PM

vonreth added inline comments.Oct 10 2018, 6:50 AM

bin/BuildSystem/BuildSystemBase.py
178–183	Any other file type we need to check?

Based on my understanding of the code this looks correct, would be nice for Kevin to check as well though as i'm not hugely familiar with Python lambda's.

bin/BuildSystem/BuildSystemBase.py
178–183	Shouldn't be no, that covers everything I can immediately think of - pkgconfig, QMake and CMake.

This revision was not accepted when it landed; it landed in state Needs Review.Oct 10 2018, 5:49 PM

Closed by commit R138:93bb276c8932: Patch .pri and .cmake files (authored by vonreth). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			bin/BuildSystem/BuildSystemBase.py (13 lines)
M			bin/Packager/CollectionPackagerBase.py (8 lines)
M			bin/Packager/MacDMGPackager.py (4 lines)
M			bin/utils.py (9 lines)

Diff 43331

bin/BuildSystem/BuildSystemBase.py

Loading...

bin/Packager/CollectionPackagerBase.py

Loading...

bin/Packager/MacDMGPackager.py

Loading...

bin/utils.py

Loading...