Differential D16037

[Slideshow Wallpaper] Fix translation of context menu actions
ClosedPublic
Actions

Authored by broulik on Oct 8 2018, 8:33 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R120:a40d95212f17: [Slideshow Wallpaper] Fix translation of context menu actions
Summary

org.kde.slideshow is duplicated at compile time, so translations aren't extracted for it.
Setting an explicit domain fixes that.

Test Plan

Plasma Wallpapers supposedly support that "root path" thing we use for applets but this patch makes it a straight-forward backport to 5.12 branch apparently this is a regression introduced by the rewrite, so only 5.14+master then

  • The "open" and "next" context menu entries on my desktop are properly translated now

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Oct 8 2018, 8:33 AM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 8 2018, 8:33 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Oct 8 2018, 8:34 AM
davidedmundson accepted this revision.Oct 8 2018, 9:04 AM
This revision is now accepted and ready to land.Oct 8 2018, 9:04 AM
broulik edited the test plan for this revision. (Show Details)Oct 8 2018, 9:06 AM
Closed by commit R120:a40d95212f17: [Slideshow Wallpaper] Fix translation of context menu actions (authored by broulik). · Explain WhyOct 8 2018, 9:08 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 43112

View Options

wallpapers/image/imagepackage/contents/ui/main.qml

Loading...