change spinner from static images to in-cpu rotation
ClosedPublic

Authored by sitter on May 13 2016, 7:20 AM.

Details

Summary

performance impact should be negligible eitherway and rotation does
certainly make for the smoothest result.

  • uses a reference image that remains unchanged to rotate from. continued rotation of the same image would degrade the quality eventually turning the image into a blur after a couple of spins and make it outright disappear after a while, hence the reference image
  • from 4 spriteimages down to one, which is always the visible one
  • SpriteImage has a new setter to change the image while also updating forwarded properties (in hindsight these should have bee functions to begin with)
  • reference images gets rotated over 2*π*timebooted (no mod since we can rotate by arbitrarily large radians anyway)

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
sitter updated this revision to Diff 3797.May 13 2016, 7:20 AM
sitter retitled this revision from to change spinner from static images to in-cpu rotation.
sitter updated this object.
sitter edited the test plan for this revision. (Show Details)
sitter added a subscriber: plasma-devel.
broulik accepted this revision.May 13 2016, 9:18 AM
broulik edited edge metadata.

Looking gorgeous now

breeze/breeze.script
125

Indentation

This revision is now accepted and ready to land.May 13 2016, 9:18 AM
sitter closed this revision.May 13 2016, 9:33 AM
sitter marked an inline comment as done.May 13 2016, 9:36 AM
sitter added inline comments.
breeze/breeze.script
125

fwiw, indentation is all over the place in this file. as of late I am thinking 2 spaces works best for the language though.