Differential D1598

when clicking a link in the kmessagewidget open the url
ClosedPublic
Actions

Authored by sitter on May 12 2016, 11:39 AM.

Details

Reviewers
bgupta
Commits
R166:875d63d9a9da: when clicking a link in the kmessagewidget open the url
R166:469791c929d6: when clicking a link in the kmessagewidget open the url

Diff Detail

Repository
R166 Spectacle
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter updated this revision to Diff 3783.May 12 2016, 11:39 AM
sitter retitled this revision from to when clicking a link in the kmessagewidget open the url.
sitter updated this object.
sitter edited the test plan for this revision. (Show Details)
sitter added a reviewer: bgupta.
bgupta requested changes to this revision.May 12 2016, 1:45 PM
bgupta edited edge metadata.

Can you do this without adding such a trivial intermediate slot? Qt5's connect allows connecting to any callable, so it should in theory accept connections to a static member just fine. I've never tried it myself though.

This revision now requires changes to proceed.May 12 2016, 1:45 PM
sitter updated this revision to Diff 3790.May 12 2016, 3:08 PM
sitter edited edge metadata.

connect to openurl directly

interstingly enough that actually works withpointer-to-member syntax, fairly magic

bgupta accepted this revision.May 12 2016, 3:45 PM
bgupta edited edge metadata.

Check the inline comment. How do you do "Fix it, then Ship it" in Differential?

Also, cherry-pick to master. Don't merge.

Thanks for the fix :-)

src/Gui/KSMainWindow.cpp
158

Since it's a static member, the "this" third arg shouldn't be required. If it works without the third arg, change it, and if it doesn't, let it be.

This revision is now accepted and ready to land.May 12 2016, 3:45 PM
Closed by commit R166:469791c929d6: when clicking a link in the kmessagewidget open the url (authored by sitter). · Explain WhyMay 13 2016, 6:46 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/Gui/KSMainWindow.cpp (4 lines)

Diff 3796

View Options

src/Gui/KSMainWindow.cpp

Loading...