Unmap PlasmaWindowInterface instead of deleting directly
ClosedPublic

Authored by graesslin on May 12 2016, 6:00 AM.

Details

Summary

The window will be cleaned up automatically once all bound resources
are destroyed. A manual delete though might cause protocol errors on
client side as the unmap and resource destroy happen together and we
are in a race condition.

To ensure that we don't leak the interface is set as the parent, so
on tear-down remaining resources will be destroyed eventually, even
if it triggers a protocol error on the client.

Diff Detail

Repository
R108 KWin
Branch
plasma-window-management-destroy
Lint
No Linters Available
Unit
No Unit Test Coverage
graesslin updated this revision to Diff 3774.May 12 2016, 6:00 AM
graesslin retitled this revision from to Unmap PlasmaWindowInterface instead of deleting directly.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptMay 12 2016, 6:00 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
graesslin updated this revision to Diff 3775.May 12 2016, 8:35 AM
  • Do not limit mouse actions to titleBarArea but allow on complete titleBarPosition
graesslin updated this revision to Diff 3777.May 12 2016, 8:37 AM

Restore to correct version. Sorry for the noise - arc failed me

hein accepted this revision.May 12 2016, 8:58 AM
hein added a reviewer: hein.
This revision is now accepted and ready to land.May 12 2016, 8:58 AM
This revision was automatically updated to reflect the committed changes.