Differential D15949

[effects/zoom] Set wrap mode for cursor texture
ClosedPublic
Actions

Authored by zzag on Oct 4 2018, 6:00 PM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Commits
R108:e9fd57285f31: [effects/zoom] Set wrap mode for cursor texture
Summary

With the Oxygen cursor theme, a visual glitch can appear in the
bottom-left corner of the cursor when the screen is zoomed in.

The reason for that is we're using GL_REPEAT for GL_TEXTURE_WRAP_S
and GL_TEXTURE_WRAP_T. So, when the linear filter samples neighboring
texels in the bottom, it can sample some texels from the top (because of
GL_REPEAT).

To fix that, we have to set the wrap mode to GL_CLAMP_TO_EDGE.

BUG: 338254
FIXED-IN: 5.14.0

Test Plan

Before:

After:

Tried other cursor themes(Breeze and Adwaita), everything looks okay.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Oct 4 2018, 6:00 PM
Restricted Application added a project: KWin. · View Herald TranscriptOct 4 2018, 6:01 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Oct 4 2018, 6:01 PM
zzag added a comment.Oct 4 2018, 6:04 PM

FIXED-IN: 5.14.0

Or 5.14.1?

davidedmundson accepted this revision.Oct 4 2018, 6:28 PM
davidedmundson added a subscriber: davidedmundson.

you can go for 5.14.0

This revision is now accepted and ready to land.Oct 4 2018, 6:28 PM
Closed by commit R108:e9fd57285f31: [effects/zoom] Set wrap mode for cursor texture (authored by zzag). · Explain WhyOct 4 2018, 6:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Meffects/zoom/zoom.cpp (4 lines)

Diff 42881

View Options

effects/zoom/zoom.cpp

Loading...