[balooctl] Fix "index" command with already indexed, but moved file
ClosedPublic

Authored by poboiko on Oct 4 2018, 1:10 PM.

Details

Summary

If I move a file (while baloo was not running) and perform balooctl index on new file
(so that document Id is not changed), it won't update the path of the file, keeping the
invalid entry in index.
Explicitly tell Baloo that we want to update everything concerning this file.

BUG: 397242
FIXED-IN: 5.52

Test Plan
  1. echo "hello world" >~/file1
  2. balooctl stop
  3. mv ~/file1 ~/file2
  4. balooctl start && balooctl index ~/file2
  5. balooshow file2 and balooshow -x <DOCUMENT_ID_OF_FILE>

The first command should show the right path, and the second command shouldn't complain about bug in Baloo (invalid index entry)

Diff Detail

Repository
R293 Baloo
Branch
fix-index-renamed (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3488
Build 3506: arc lint + arc unit
poboiko created this revision.Oct 4 2018, 1:10 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptOct 4 2018, 1:10 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
poboiko requested review of this revision.Oct 4 2018, 1:10 PM
ngraham accepted this revision.Oct 5 2018, 11:32 PM
ngraham added a subscriber: ngraham.

Verified that this fixes https://bugs.kde.org/show_bug.cgi?id=397242. Can you add the following to the summary section:

BUG: 397242
FIXED-IN: 5.52

Also please commit after 5.51 is tagged tomorrow.

This revision is now accepted and ready to land.Oct 5 2018, 11:32 PM
poboiko edited the summary of this revision. (Show Details)Oct 6 2018, 10:08 AM
poboiko closed this revision.Oct 8 2018, 10:11 PM