Remove superfluous KAuthorised check with new name
ClosedPublic
Actions

Authored by davidedmundson on May 11 2016, 10:43 PM.

Details

Reviewers

Group Reviewers

Commits

Summary

We already have code in plasma that will hide this action using the KAuthorised ID "plasma/plasmashell/unlockedDesktop".

Including a second ID that will only have an effect in one place isn't
very useful.

Test Plan

Set
[KDE Action Restrictions][$i]
plasma/plasmashell/unlockedDesktop=false

checked I couldn't see this menu

Repository

R120 Plasma Workspace

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

davidedmundson retitled this revision from to Remove superfluous KAuthorised check with new name.

davidedmundson updated this object.

davidedmundson edited the test plan for this revision. (Show Details)

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

Where's the unlockedDesktop action defined?

This revision is now accepted and ready to land.May 12 2016, 4:00 AM

ShellCorona:390 which then calls Corona::setImmutability(Plasma::Types::SystemImmutable)

which is basically Plasma's own custom KAuthorized system

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			containmentactions/contextmenu/menu.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	3772	6abc546		May 11 2016, 10:43 PM	★	★
Diff 2	3784	153393a	rPLASMAWORKSPACEaee6bfe310d9e10726ac778363e14b0de7f02653	May 12 2016, 12:05 PM	★	★