CMakeManager::specialLanguageObjectNavigationWidget() implementation was
only checking for letters and _, thus not properly detecting ids with digits
inside, e.g. the CMPxxxx policy ids.
Details
Details
- Reviewers
apol - Group Reviewers
KDevelop - Commits
- R32:a46bd1c97123: cmake: fix detecting ids with digits inside on a cursor position
Hovering over "CMP0071" in a CMakeLists.txt or presseing Alt now triggers
the navigation widget with the respective documentation.
Doing the same for CMake functions and variables still works as before
Diff Detail
Diff Detail
- Repository
- R32 KDevelop
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
A bit sad i blew up the code here. But then when I first looked at the code I was wondering about all the corner cases, so being a bit more explicit might not hurt. Moving into separate method at least helps keeping the actual method small and understandable.
Second while loop done to be consistent a bit with first one, undecided wheter another loop would be better, so looking for opinions here :)