Differential D15909

Fix compile failure on Windows targets
ClosedPublic
Actions

Authored by zrax on Oct 2 2018, 8:51 PM.

Details

Reviewers
dhaumann
Commits
R246:2e364ebbf240: Fix compile failure on Windows targets
Summary

Fix a compile failure on Windows due to the use of QSysInfo enums which are not fully qualified.

Diff Detail

Repository
R246 Sonnet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zrax created this revision.Oct 2 2018, 8:51 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 2 2018, 8:51 PM
zrax requested review of this revision.Oct 2 2018, 8:51 PM
dhaumann accepted this revision.Oct 3 2018, 7:12 AM
dhaumann added a subscriber: dhaumann.

Lgtm.

This revision is now accepted and ready to land.Oct 3 2018, 7:12 AM
dhaumann added a comment.Oct 3 2018, 7:14 AM

Btw, can you commit yourself, or shall we push this? If so, can someone take care of this, since I am not available for the next 10 days.

zrax added a comment.Oct 3 2018, 4:25 PM

No, I do not have push permissions.

Closed by commit R246:2e364ebbf240: Fix compile failure on Windows targets (authored by zrax, committed by krop). · Explain WhyOct 3 2018, 9:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/plugins/voikko/voikkodict.cpp (2 lines)

Diff 42816

View Options

src/plugins/voikko/voikkodict.cpp

Loading...